fix: boolean group field broken with setters #2985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit a8e930f and detected 0 issues on this pull request. View more on Code Climate. |
|
hey @binarygit. can you please add some tests for this PR? The use case that we're fixing here is this one where the value wasn't been forwarded to a setter on the model. I'm here to answer your questions. |
|
Sure @adrianthedev. I hope it's okay if I get to this tomorrow morning 🙏 |
* Check true fields in edit view * Refactor and Write tests * Lint * Set permissions setter via attr_writer * Lint
Paul-Bob
approved these changes
Jul 17, 2024
|
@binarygit you can work directly on this branch, let's check what's wrong with the tests & lint |
Co-authored-by: Adrian Marin <adrian@adrianthedev.com>
6 tasks
|
This PR has been merged into Please check the release guide for more information. |
Paul-Bob
added a commit
that referenced
this pull request
Jul 19, 2024
Paul-Bob
added a commit
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where setters were not being properly used with boolean group fields.
Checklist: