Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

date and date_time can't be used as computed fields #3023

Closed
2 of 6 tasks
adrianthedev opened this issue Jul 19, 2024 · 4 comments · Fixed by #3032
Closed
2 of 6 tasks

date and date_time can't be used as computed fields #3023

adrianthedev opened this issue Jul 19, 2024 · 4 comments · Fixed by #3032
Assignees
@pravo23
Labels
Bug Something isn't working Good first issue Good for newcomers Help wanted We could use some help with this

Comments

@adrianthedev
Copy link
Collaborator

Describe the bug

They still use model[id] and they shoudl use model.send(id).
Same for getters and setters.

Approach

Change it to send as we did on #2985

Impact

  • High impact (It makes my app un-usable.)
  • Medium impact (I'm annoyed, but I'll live.)
  • Low impact (It's really a tiny thing that I could live with.)

Urgency

  • High urgency (I can't continue development without it.)
  • Medium urgency (I found a workaround, but I'd love to have it fixed.)
  • Low urgency (It can wait. I just wanted you to know about it.)
@adrianthedev adrianthedev moved this to Next up in Issues Jul 19, 2024
@adrianthedev adrianthedev added Bug Something isn't working Help wanted We could use some help with this Good first issue Good for newcomers labels Jul 19, 2024
@pravo23
Copy link
Contributor

pravo23 commented Jul 19, 2024

Hi, Can I work on this?

@Paul-Bob
Copy link
Contributor

Yes @pravo23, we appreciate it!

@adrianthedev
Copy link
Collaborator Author

Thank you @pravo23!

@pravo23 pravo23 mentioned this issue Jul 20, 2024
Merged
4 tasks
@pjmuller
Copy link

thanks @pravo23 , I've checked your PR and looks what we need ❤️

@github-project-automation github-project-automation bot moved this from Next up to Done in Issues Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pravo23 pravo23

Labels
Bug Something isn't working Good first issue Good for newcomers Help wanted We could use some help with this
Projects
Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: model assignment pravo23/avo
4 participants
@adrianthedev @pjmuller @pravo23 @Paul-Bob