Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: normalize tag labels #2888

Merged
merged 21 commits into from
Jun 27, 2024
Merged

fix: normalize tag labels #2888

merged 21 commits into from
Jun 27, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jun 25, 2024

Description

Fixes #2836

Deprecated fetch_labels in order of format_using and ensure the use of correct label when format_using returns a hash with label and value keys.

TODO after approval:

  • Document fetch_labels deprecation and suggest format_using usage
  • Document possible usages of format_using on tags field
  • Tests

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob marked this pull request as draft June 25, 2024 10:00
@github-actions github-actions bot added the Fix label Jun 25, 2024
Copy link

codeclimate bot commented Jun 25, 2024

Code Climate has analyzed commit 082a9b5 and detected 0 issues on this pull request.

View more on Code Climate.

lib/avo/fields/base_field.rb Outdated Show resolved Hide resolved
lib/avo/fields/base_field.rb Outdated Show resolved Hide resolved
@Paul-Bob Paul-Bob self-assigned this Jun 25, 2024
@Paul-Bob Paul-Bob requested a review from adrianthedev June 25, 2024 11:11
@Paul-Bob Paul-Bob marked this pull request as ready for review June 25, 2024 11:12
spec/dummy/app/avo/resources/course.rb Outdated Show resolved Hide resolved
spec/dummy/app/avo/resources/course.rb Outdated Show resolved Hide resolved
spec/dummy/app/avo/resources/course.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tags_spec.rb Outdated Show resolved Hide resolved
@Paul-Bob Paul-Bob merged commit 31e277f into main Jun 27, 2024
27 checks passed
@Paul-Bob Paul-Bob deleted the fix/normalize_tags branch June 27, 2024 15:07
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

value and label switched in tags field
1 participant