-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: add action icon #2628
feature: add action icon #2628
Conversation
Code Climate has analyzed commit 8293d25 and detected 0 issues on this pull request. View more on Code Climate. |
quit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets make "play"
as action's default icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's purge next_action
since we're not using it anymore
@gabrielgiroe1 I let some comments for some last tweaks, otherwise the PR looks great, thank you! This is a cool improvement! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I haven't tested it.
I left one suggestions and one question.
GJ! I wanted this for such a long time!
lib/avo/base_resource.rb
Outdated
@@ -310,8 +314,8 @@ def fetch_cards | |||
end | |||
|
|||
# def action / def filter / def scope | |||
define_method entity do |entity_class, arguments: {}| | |||
entity_loader(entity).use({class: entity_class, arguments: arguments}) | |||
define_method entity do |entity_class, arguments: {}, icon: "play"| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to specify a default here as well? Wouldn't the initializer default take precedence?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we must specify a default value. I tried as below and it won't get a default icon value.👇
define_method entity do |entity_class, arguments: {}, icon: nil|
Also, let's see the docs. |
This PR has been merged into Please check the release guide for more information. |
Description
Add action icon and action divider for better organization and clarity.
Fixes #2592
Checklist: