Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add action icon & action divider #2592

Closed
gabrielgiroe1 opened this issue Mar 13, 2024 · 3 comments · Fixed by #2628
Closed

add action icon & action divider #2592

gabrielgiroe1 opened this issue Mar 13, 2024 · 3 comments · Fixed by #2628
Assignees
Labels
😎 Cool Enhancement Not necessarily a feature, but something has improved Feature

Comments

@gabrielgiroe1
Copy link
Contributor

gabrielgiroe1 commented Mar 13, 2024

Feature

Add action icon and action divider for better organization and clarity.

Screenshots or screen recordings

Screenshot 2024-03-13 at 14 52 12

@Paul-Bob Paul-Bob moved this to Next up in Issues Mar 13, 2024
@Paul-Bob Paul-Bob added Enhancement Not necessarily a feature, but something has improved Feature 😎 Cool labels Mar 13, 2024
@Paul-Bob
Copy link
Contributor

Paul-Bob commented Mar 22, 2024

API suggestion:

  def actions
    action Avo::Actions::ToggleInactive, icon: "heroicons/outline/globe"
    action Avo::Actions::ToggleAdmin
    divider
    action Avo::Actions::Sub::DummyAction
    action Avo::Actions::DownloadFile, icon: "heroicons/outline/globe"
    divider
    action Avo::Actions::Test::NoConfirmationRedirect
    action Avo::Actions::Test::CloseModal
  end

Maybe as first iteration let's try:

  def actions
    action Avo::Actions::ToggleInactive, arguments: { icon: "heroicons/outline/globe" }
    action Avo::Actions::ToggleAdmin
    divider
    action Avo::Actions::Sub::DummyAction
    action Avo::Actions::DownloadFile, arguments: { icon: "heroicons/outline/globe" }
    divider
    action Avo::Actions::Test::NoConfirmationRedirect
    action Avo::Actions::Test::CloseModal
  end

@gabrielgiroe1 gabrielgiroe1 moved this from Next up to In Progress in Issues Mar 22, 2024
@adrianthedev
Copy link
Collaborator

icon being a first-party option of an action, I would go with action Avo::Actions::ToggleInactive, icon: "heroicons/outline/globe" instead of arguments: {icon: ... }
It makes the API more consistent.

@Paul-Bob
Copy link
Contributor

Agree

@gabrielgiroe1 gabrielgiroe1 moved this from In Progress to In Review in Issues Mar 26, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Issues Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😎 Cool Enhancement Not necessarily a feature, but something has improved Feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants