Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing caption text at end of file. #3675

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Handle missing caption text at end of file. #3675

merged 1 commit into from
Oct 17, 2019

Conversation

bkeese
Copy link
Contributor

@bkeese bkeese commented Oct 17, 2019

Fixes #3668

cjcolvar
cjcolvar previously approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks good to me, but could you create a PR upstream so we don't have to remember this override the next time we upgrade? Looks like it should be this line: https://github.com/mediaelement/mediaelement/blob/master/src/js/features/tracks.js#L902

@bkeese
Copy link
Contributor Author

bkeese commented Oct 17, 2019

Upstream PR: mediaelement/mediaelement#2702

@cjcolvar cjcolvar merged commit cc528a5 into develop Oct 17, 2019
@cjcolvar cjcolvar deleted the captions_fix branch October 17, 2019 15:21
@Dananji Dananji mentioned this pull request Sep 11, 2020
Closed
@Dananji Dananji mentioned this pull request Oct 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bkeese @cjcolvar