Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebVTT Files Don't Render When Ending With No Cue Text #4899

Closed
joncameron opened this issue Sep 30, 2022 · 5 comments
Closed

WebVTT Files Don't Render When Ending With No Cue Text #4899

joncameron opened this issue Sep 30, 2022 · 5 comments
Assignees
Labels

Comments

@joncameron
Copy link
Contributor

Current Behavior

When a VTT file ends with a cue that does not have text associated, the closed captions do not display in the player.

VTT Example

00:24:25.760 --> 00:24:29.110 align:middle line:90%
[MUSIC PLAYING]

00:24:29.110 --> 00:25:56.000 align:middle line:90%
EOF

Expected Behavior

VTT files display normally when the file ends with a timecode without text information

MediaElement Error

Uncaught TypeError: Cannot read properties of undefined (reading 'trim')
    at Object.parse (mejs4_player-89828209b971fb12ea982fda09f81057bdb20080daac76da242fa939497e715d.js:13:29932)
    at mejs4_player-89828209b971fb12ea982fda09f81057bdb20080daac76da242fa939497e715d.js:13:23090
    at a.onreadystatechange (mejs4_player-89828209b971fb12ea982fda09f81057bdb20080daac76da242fa939497e715d.js:16:18387)
@joncameron joncameron added the bug label Sep 30, 2022
@Dananji
Copy link
Contributor

Dananji commented Oct 11, 2022

@joncameron I think, this issue was reported earlier (#3668)?
Brian had put in a fix for that (#3675) for it then, and it was pushed upstream.

@joncameron
Copy link
Contributor Author

@Dananji Testing again on dev the error is different (Uncaught TypeError: text is undefined) but the behavior is still the same—the VTT file does not render.

Example item with two sections: https://avalon-dev.dlib.indiana.edu/media_objects/1z40ks800

@joncameron
Copy link
Contributor Author

@joncameron Upload an example file.

@Dananji Dananji self-assigned this Oct 13, 2022
@joncameron
Copy link
Contributor Author

Tested and confirmed to work on staging.

@joncameron
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants