Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #466 Updates rjeczalik/notify 0.9.2 -> 0.9.3 because it solves a deprecation on MacOS Ventura #467

Conversation

itinance
Copy link
Contributor

Fixes #466

This PR upgrades the library https://github.com/rjeczalik/notify from 0.9.2 to 0.9.3, which fixes MacOS deprecation and eliminates deprecated io/ioutils.

Description for the fix of notify-library: rjeczalik/notify#212

Why this should be merged

  • It fixes deprecates on MacOS 13 and added necessary changes for future MacOS-versions
  • it gets rid of now-deprecated Go-library io/ioutils

How this works

The fix for 0.9.2 can be found here: rjeczalik/notify#215, adding some necessary changes for future-MacOS versions.
It also includes rjeczalik/notify#214, which gets rid of now-deprecated Go-library io/ioutils

How this was tested

  • unit tests can be found at https://github.com/rjeczalik/notify
  • I compiled a EVM-subnet with and without this commit on MacOS Ventura after cleaning the Go Cache, and can confirm that the deprecate-warning disappears with this

@itinance itinance force-pushed the upgrade-notify-to-fix-deprecations-on-macos-ventura branch from 07c0c6a to 09bbcd2 Compare January 30, 2023 18:22
@itinance itinance force-pushed the upgrade-notify-to-fix-deprecations-on-macos-ventura branch from 362808c to db2475a Compare January 30, 2023 18:23
@itinance
Copy link
Contributor Author

signed and go mod tidy

@darioush
Copy link
Collaborator

darioush commented Feb 2, 2023

Thanks for your PR.
It seems upstream has taken a slightly different path: ethereum/go-ethereum#26176
Once the next version of go-ethereum is released, these changes will reflected in subnet-evm soon.

@itinance
Copy link
Contributor Author

itinance commented Feb 2, 2023

I see. Pls feel free to close this PR then if we want to go with next upstream-update instead.

@darioush darioush closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation-Warning when building on MacOS Ventura (notify-library), PR attached
2 participants