Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation-Warning when building on MacOS Ventura (notify-library), PR attached #466

Closed
itinance opened this issue Jan 29, 2023 · 2 comments
Closed

Deprecation-Warning when building on MacOS Ventura (notify-library), PR attached #466

itinance opened this issue Jan 29, 2023 · 2 comments
Labels
dependencies Pull requests that update a dependency file
Milestone
subnet-evm@Future...

Comments

@itinance
Copy link
Contributor

With MacOS Ventura, a deprecation warning appears when building with github.com/rjeczalik/notify.git 0.9.2

0.9.3 already contains the fix for that. I am going to submit PR as well.

Description: rjeczalik/notify#212
@itinance itinance mentioned this issue Jan 29, 2023
Closed
@darioush
Copy link
Collaborator

darioush commented Feb 2, 2023

Linking relevant issue: ethereum/go-ethereum#26168

@aaronbuchwald aaronbuchwald added this to the Subnet-EVM@v0.4.11 milestone Feb 21, 2023
@aaronbuchwald aaronbuchwald added the dependencies Pull requests that update a dependency file label Feb 21, 2023
@aaronbuchwald aaronbuchwald moved this to Done ✅ in EVM Jun 13, 2023
@aaronbuchwald aaronbuchwald moved this from Done ✅ to Backlog 🗄 in EVM Jun 13, 2023
@darioush
Copy link
Collaborator

darioush commented Oct 3, 2023

This issue is resolved as we no longer depend on https://github.com/rjeczalik/notify (after we bumped the go-ethereum dependency we are using github.com/fsnotify/fsnotify)

@darioush darioush closed this as completed Oct 3, 2023
@github-project-automation github-project-automation bot moved this from Backlog 🗄 to Done ✅ in EVM Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
No open projects
EVM
Archived in project
Milestone
subnet-evm@Future Release
3 participants
@itinance @darioush @aaronbuchwald