tx indexer fix: avoids using sleep in test #1151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
commented
Apr 16, 2024
| @@ -483,6 +484,7 @@ func (bc *BlockChain) maintainTxIndex() { | |||
| if head := bc.CurrentBlock(); head != nil && head.Number.Uint64() > txLookupLimit { | |||
| done = make(chan struct{}) | |||
| tail := rawdb.ReadTxIndexTail(bc.db) | |||
| bc.wg.Add(1) | |||
There was a problem hiding this comment.
alternatively I think we can check if done != nil { ... } like its done in bc.quit, but also wg seems fine.
ceyonur
reviewed
Apr 16, 2024
darioush
commented
Apr 17, 2024
Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org>
darioush
commented
Apr 17, 2024
Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org>
ceyonur
approved these changes
Apr 17, 2024
ceyonur
added a commit
that referenced
this pull request
Apr 17, 2024
* fix unindexor in state sync * fix lint * fix flaky test * Update core/blockchain_test.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * Update core/test_blockchain.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * fix reviews * readd delay for index init * Update core/rawdb/accessors_state_sync.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> * tx indexer fix: avoids using sleep in test (#1151) * avoids using sleep in test * track all goroutines * trying harder * add some debug information in case of fail * Update core/blockchain.go Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> * Update core/blockchain.go Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> --------- Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> --------- Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com> Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we can wait for the eventually to pass before closing the chain to avoid adding a sleep