Tx indexing fix #1131
Merged
Tx indexing fix #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
863ad55 to
2ac56a4
Compare
e88eab5 to
51646de
Compare
darioush
reviewed
Apr 15, 2024
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Ceyhun Onur <ceyhunonur54@gmail.com>
* avoids using sleep in test * track all goroutines * trying harder * add some debug information in case of fail * Update core/blockchain.go Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> * Update core/blockchain.go Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org> --------- Signed-off-by: Darioush Jalali <darioush.jalali@avalabs.org>
darioush
previously approved these changes
Apr 17, 2024
darioush
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently uindexor stucks at first block if state sync is enabled. This fixes the problem by skipping the last indexed tail to last state synced block.
Closes: ava-labs/coreth#405
How this works
It jumps to the latest state synced block if lookup limit is non-zero, in cases:
1- At startup to repair with latest state synced block, in case the VM already started normal operations after a successful state sync.
2- When a state sync is completed
It also enables unindexor to perform a startup cleanup with respect to the latest accepted block.
How this was tested
Added UT, will deploy to a bugged node.
How is this documented
No need