Meag rewordings #1978
Merged
Meag rewordings #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Meaghan FitzGerald <meag.fitz@avalabs.org>
cc495c5
into
subnet-create-explore-ux
11 of 31 checks passed
felipemadero
added a commit
that referenced
this pull request
Jul 25, 2024
* add skel * add missing files * check for forge to have been installed * add comments * start automating foundry install * added automated froundry install * start working agains teleporter repo * deploying contract given abi and bin files * adding destination deploy * deploying the destination * ux design 2 for bridge deploy of fuji * add popular token info list * move to new file * add blockchain alias to popular tokens json * start using teleporter bridge deploy * adddress suggestions * fix recommended * update to latest esp * integrate allow list stuff * nit * niy * VM option * add version option * add gas fees stub * add remaining prompts * address #1927 * Meag rewordings (#1978) * ETD subnet-evm vs CustomVM * ETD: native vs erc20 * ETD: to burn or not to burn * finish explaining * Update cmd/subnetcmd/create.go Signed-off-by: Meaghan FitzGerald <meag.fitz@avalabs.org> --------- Signed-off-by: Meaghan FitzGerald <meag.fitz@avalabs.org> * [Subnet Create Explore] Rewording Martin (#2002) * Select VM, native token, token allocation, token supply, transaction fees, dynamic fees * transaction and smart contract deployer allowlist * fix typo * introduce const for explainOption * Add missing explain option * Fix nits and incorporated user feedback * genesis params start making more sense * add useTeleporter * gas token prompt closed * fee config ok * add missing file * vm type cleanup * more cleanup * move all subnet evm prompts to the same file * nits * lint * nit * lint * move prompts to vm package * partial work * added fee config * added allocations and teleporter stuff * added precompiles * createEvm is ready * start making sense * add teleporter prompt to create custom * add check for compatible subnet evm genesis when asking for teleporter on custom * add tokensymbol to custom vm * nit * fix relayer conf for the moment * nits * lint * unit test * fix e2e * fix flag exclusion for genesis agains tokenSymbol * Update cmd/subnetcmd/upgradecmd/generate.go Co-authored-by: Martin Eckardt <martin.eckardt@avalabs.org> Signed-off-by: felipemadero <felipe.madero@gmail.com> * address PR comments --------- Signed-off-by: Meaghan FitzGerald <meag.fitz@avalabs.org> Signed-off-by: felipemadero <felipe.madero@gmail.com> Co-authored-by: Meaghan FitzGerald <meag.fitz@avalabs.org> Co-authored-by: Martin Eckardt <martin.eckardt@avalabs.org>
felipemadero
added a commit
that referenced
this pull request
Jul 25, 2024
…(adding a flag for it) (#2048) * add skel * add missing files * check for forge to have been installed * add comments * start automating foundry install * added automated froundry install * start working agains teleporter repo * deploying contract given abi and bin files * adding destination deploy * deploying the destination * ux design 2 for bridge deploy of fuji * add popular token info list * move to new file * add blockchain alias to popular tokens json * start using teleporter bridge deploy * adddress suggestions * fix recommended * update to latest esp * integrate allow list stuff * nit * niy * VM option * add version option * add gas fees stub * add remaining prompts * address #1927 * Meag rewordings (#1978) * ETD subnet-evm vs CustomVM * ETD: native vs erc20 * ETD: to burn or not to burn * finish explaining * Update cmd/subnetcmd/create.go Signed-off-by: Meaghan FitzGerald <meag.fitz@avalabs.org> --------- Signed-off-by: Meaghan FitzGerald <meag.fitz@avalabs.org> * [Subnet Create Explore] Rewording Martin (#2002) * Select VM, native token, token allocation, token supply, transaction fees, dynamic fees * transaction and smart contract deployer allowlist * fix typo * introduce const for explainOption * Add missing explain option * Fix nits and incorporated user feedback * genesis params start making more sense * add useTeleporter * gas token prompt closed * fee config ok * add missing file * vm type cleanup * more cleanup * move all subnet evm prompts to the same file * nits * lint * nit * lint * move prompts to vm package * partial work * added fee config * added allocations and teleporter stuff * added precompiles * createEvm is ready * start making sense * add teleporter prompt to create custom * add check for compatible subnet evm genesis when asking for teleporter on custom * add tokensymbol to custom vm * nit * fix relayer conf for the moment * nits * lint * unit test * fix e2e * fix flag exclusion for genesis agains tokenSymbol * latest changes besides ux changes * also include latest release download in defaults * address PR comments * Update cmd/subnetcmd/upgradecmd/generate.go Co-authored-by: Martin Eckardt <martin.eckardt@avalabs.org> Signed-off-by: felipemadero <felipe.madero@gmail.com> * address PR comments * Use avacloud gas limit settings + add dynamic fees/not dynamic fees option (#2050) * use avacloud values for standard gas control * nit * also change upgrade * fix defaults msg --------- Signed-off-by: Meaghan FitzGerald <meag.fitz@avalabs.org> Signed-off-by: felipemadero <felipe.madero@gmail.com> Co-authored-by: Meaghan FitzGerald <meag.fitz@avalabs.org> Co-authored-by: Martin Eckardt <martin.eckardt@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added explanations to the options for creating a subnet with the cli