Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[subnet create explore] Always deploy Teleporter and registry if Subnet uses token from another blockchain as native token #1927

Closed
martineckardt opened this issue Jun 4, 2024 · 1 comment
Closed

[subnet create explore] Always deploy Teleporter and registry if Subnet uses token from another blockchain as native token #1927

martineckardt opened this issue Jun 4, 2024 · 1 comment
Assignees
@felipemadero

Comments

@martineckardt
Copy link
Contributor

When a user selects A token from another blockchain always deploy Teleporter & Registry:

Current implementation

root@codespaces-8559b9:/workspaces/avalanche-cli# avalanche subnet create testTokenFromAnotherBlockchain
✔ Subnet-EVM
✔ Use latest release version
Chain ID: 999999

✔ A token from another blockchain

[...}

Use the arrow keys to navigate: ↓ ↑ → ← 
? Do you want to connect your blockchain with other blockchains or C-Chain? (Deploy Teleporter and Registry): 
  ▸ Yes, I want my blockchain to be able to interoperate with other blockchains and the C-Chain
    No, I want to run my blockchain isolated
    Explain the difference

Requested Change

Skip question if A token from another blockchain is selected:

image
felipemadero added a commit that referenced this issue Jun 12, 2024
@felipemadero
address #1927
41776a0
@felipemadero
Copy link
Collaborator

Addressed on 41776a0

@github-project-automation github-project-automation bot moved this from Backlog 🗄️ to Done ✅ in Platform Engineering Group Jun 12, 2024
felipemadero added a commit that referenced this issue Jul 25, 2024
@felipemadero @meaghanfitzgerald @martineckardt
New subnet create ux (#2027)
35522f4 
* add skel

* add missing files

* check for forge to have been installed

* add comments

* start automating foundry install

* added automated froundry install

* start working agains teleporter repo

* deploying contract given abi and bin files

* adding destination deploy

* deploying the destination

* ux design 2 for bridge deploy of fuji

* add popular token info list

* move to new file

* add blockchain alias to popular tokens json

* start using teleporter bridge deploy

* adddress suggestions

* fix recommended

* update to latest esp

* integrate allow list stuff

* nit

* niy

* VM option

* add version option

* add gas fees stub

* add remaining prompts

* address #1927

* Meag rewordings (#1978)

* ETD subnet-evm vs CustomVM

* ETD: native vs erc20

* ETD: to burn or not to burn

* finish explaining

* Update cmd/subnetcmd/create.go

Signed-off-by: Meaghan FitzGerald <meag.fitz@avalabs.org>

---------

Signed-off-by: Meaghan FitzGerald <meag.fitz@avalabs.org>

* [Subnet Create Explore] Rewording Martin (#2002)

* Select VM, native token, token allocation, token supply, transaction fees, dynamic fees

* transaction and smart contract deployer allowlist

* fix typo

* introduce const for explainOption

* Add missing explain option

* Fix nits and incorporated user feedback

* genesis params start making more sense

* add useTeleporter

* gas token prompt closed

* fee config ok

* add missing file

* vm type cleanup

* more cleanup

* move all subnet evm prompts to the same file

* nits

* lint

* nit

* lint

* move prompts to vm package

* partial work

* added fee config

* added allocations and teleporter stuff

* added precompiles

* createEvm is ready

* start making sense

* add teleporter prompt to create custom

* add check for compatible subnet evm genesis when asking
for teleporter on custom

* add tokensymbol to custom vm

* nit

* fix relayer conf for the moment

* nits

* lint

* unit test

* fix e2e

* fix flag exclusion for genesis agains tokenSymbol

* Update cmd/subnetcmd/upgradecmd/generate.go

Co-authored-by: Martin Eckardt <martin.eckardt@avalabs.org>
Signed-off-by: felipemadero <felipe.madero@gmail.com>

* address PR comments

---------

Signed-off-by: Meaghan FitzGerald <meag.fitz@avalabs.org>
Signed-off-by: felipemadero <felipe.madero@gmail.com>
Co-authored-by: Meaghan FitzGerald <meag.fitz@avalabs.org>
Co-authored-by: Martin Eckardt <martin.eckardt@avalabs.org>
felipemadero added a commit that referenced this issue Jul 25, 2024
@felipemadero @meaghanfitzgerald @martineckardt
Add prompt for default values and remove prompt for remote gas token …
c7faf1a 
…(adding a flag for it) (#2048)

* add skel

* add missing files

* check for forge to have been installed

* add comments

* start automating foundry install

* added automated froundry install

* start working agains teleporter repo

* deploying contract given abi and bin files

* adding destination deploy

* deploying the destination

* ux design 2 for bridge deploy of fuji

* add popular token info list

* move to new file

* add blockchain alias to popular tokens json

* start using teleporter bridge deploy

* adddress suggestions

* fix recommended

* update to latest esp

* integrate allow list stuff

* nit

* niy

* VM option

* add version option

* add gas fees stub

* add remaining prompts

* address #1927

* Meag rewordings (#1978)

* ETD subnet-evm vs CustomVM

* ETD: native vs erc20

* ETD: to burn or not to burn

* finish explaining

* Update cmd/subnetcmd/create.go

Signed-off-by: Meaghan FitzGerald <meag.fitz@avalabs.org>

---------

Signed-off-by: Meaghan FitzGerald <meag.fitz@avalabs.org>

* [Subnet Create Explore] Rewording Martin (#2002)

* Select VM, native token, token allocation, token supply, transaction fees, dynamic fees

* transaction and smart contract deployer allowlist

* fix typo

* introduce const for explainOption

* Add missing explain option

* Fix nits and incorporated user feedback

* genesis params start making more sense

* add useTeleporter

* gas token prompt closed

* fee config ok

* add missing file

* vm type cleanup

* more cleanup

* move all subnet evm prompts to the same file

* nits

* lint

* nit

* lint

* move prompts to vm package

* partial work

* added fee config

* added allocations and teleporter stuff

* added precompiles

* createEvm is ready

* start making sense

* add teleporter prompt to create custom

* add check for compatible subnet evm genesis when asking
for teleporter on custom

* add tokensymbol to custom vm

* nit

* fix relayer conf for the moment

* nits

* lint

* unit test

* fix e2e

* fix flag exclusion for genesis agains tokenSymbol

* latest changes besides ux changes

* also include latest release download in defaults

* address PR comments

* Update cmd/subnetcmd/upgradecmd/generate.go

Co-authored-by: Martin Eckardt <martin.eckardt@avalabs.org>
Signed-off-by: felipemadero <felipe.madero@gmail.com>

* address PR comments

* Use avacloud gas limit settings + add dynamic fees/not dynamic fees option (#2050)

* use avacloud values for standard gas control

* nit

* also change upgrade

* fix defaults msg

---------

Signed-off-by: Meaghan FitzGerald <meag.fitz@avalabs.org>
Signed-off-by: felipemadero <felipe.madero@gmail.com>
Co-authored-by: Meaghan FitzGerald <meag.fitz@avalabs.org>
Co-authored-by: Martin Eckardt <martin.eckardt@avalabs.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipemadero felipemadero

Labels
None yet
Projects
Platform Engineering Group
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@martineckardt @felipemadero