-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(single_lidar_common_launch): load from parameter #3
feature(single_lidar_common_launch): load from parameter #3
Conversation
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@mojomex @beginningfan could you review this, thanks |
@vividf Thanks for your work. LGTM. |
@vividf Thanks for your work. LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change
nodes.append(
ComposableNode(
package="pointcloud_preprocessor",
plugin="pointcloud_preprocessor::CropBoxFilterComponent",
name="crop_box_filter_self",
to
nodes.append(
ComposableNode(
package="autoware_pointcloud_preprocessor",
plugin="autoware::pointcloud_preprocessor::CropBoxFilterComponent",
name="crop_box_filter_self",
Similar modifications should also be made to other related nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When I update to the latest Autoware, there will be an error when compiling that there is no package pointcloud_preprocessor, You must modify it to autoware_pointcloud_preprocessor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks, I didn't see the changes you mentioned.
I thought it was a layout issue.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
@cyn-liu If everything works well, please merge this PR :) |
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
remove the default parameter, thus the launcher needs to be modified.
related link: