Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2e_simulator): add argument for v2x traffic signals in launch #997

Conversation

lchojnack
Copy link
Contributor

@lchojnack lchojnack commented May 23, 2024

Description

Add argument for v2x traffic signals in e2e_simulator launch.
The topic name is compatible with AWSIM labs V2X publisher.

Part of

Tests performed

The same as in autowarefoundation/AWSIM-Labs#76

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…nals in e2e_simulator launch

Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label May 23, 2024
@lchojnack lchojnack self-assigned this May 23, 2024
xmfcx
xmfcx previously approved these changes May 23, 2024
@xmfcx xmfcx changed the title feat(autoware_launch/e2e_simulator): add argument for v2x traffic signals in e2e_simulator launch feat(e2e_simulator): add argument for v2x traffic signals in launch May 23, 2024
@xmfcx xmfcx dismissed their stale review May 23, 2024 11:11

will check something

@xmfcx
Copy link
Contributor

xmfcx commented May 23, 2024

Instead of modifying this, I think since most AWSIM topics directly publish to Autoware's defaults, it's easier to just change the AWSIM Labs side to use the existing topic: /perception/traffic_light_recognition/external/traffic_signals and keep here without changes.

@lchojnack
Copy link
Contributor Author

Thanks for your suggestion. I close this PR.

@lchojnack lchojnack closed this May 23, 2024
@lchojnack lchojnack deleted the feature/v2x-traffic-signals branch May 23, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants