Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable v2i feature by default #76

Merged
merged 5 commits into from
May 27, 2024

Conversation

lchojnack
Copy link
Collaborator

@lchojnack lchojnack commented May 23, 2024

Description

Enable V2I feature by default
Screenshot_20240523_091757

Related links

Part of

Linked with

Tests performed

  • Check if data is published on /perception/traffic_light_recognition/external/traffic_signals topic with a given frequency 10Hz

  • Check if traffic lights are correctly detected when the EGO's camera is turned off

    Screenshot_20240523_115252
    Screenshot_20240523_115315
    Screenshot_20240523_115308

Effects on system behavior

Not applicable.

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
@lchojnack lchojnack self-assigned this May 23, 2024
Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
lchojnack added 2 commits May 23, 2024 15:40
Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
@mozhoku
Copy link
Collaborator

mozhoku commented May 24, 2024

I've tested this in editor with Autoware:

It's working 👍

@xmfcx
Copy link

xmfcx commented May 27, 2024

@lchojnack could you rebase to the latest main? If the changes you've made in the scene, doing those changes from scratch on the clean scene file from the main branch would be good.

Since:

Signed-off-by: Lukasz Chojnacki <lukasz.chojnacki@robotec.ai>
@lchojnack
Copy link
Collaborator Author

@xmfcx done

@mozhoku mozhoku merged commit a99f67e into autowarefoundation:main May 27, 2024
6 of 7 checks passed
@lchojnack lchojnack mentioned this pull request Jun 6, 2024
6 tasks
@lchojnack lchojnack deleted the feature/enable-v2i branch July 15, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants