Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tracking_object_merger): fix unknown is not associated problem #825

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Jan 26, 2024

Description

This PR fixes wrong association settings for tracking object merger.

  • before: unknown class was not associated each other
  • after: unknown objects will associated each other

Tests performed

Tested lsim.

Effects on system behavior

Less unknown objects.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi requested a review from yukkysaito January 26, 2024 03:17
@YoshiRi YoshiRi marked this pull request as ready for review January 26, 2024 03:17
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi merged commit 626b48b into autowarefoundation:main Jan 26, 2024
9 of 10 checks passed
@YoshiRi YoshiRi deleted the fix/tracking_object_merger_association_fix branch January 26, 2024 03:50
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Feb 6, 2024
…utowarefoundation#825)

fix: unknown is not associated problem

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 13, 2024
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
…towarefoundation#825 (autowarefoundation#570)

fix(tracking_object_merger): fix unknown is not associated problem (autowarefoundation#825)

fix: unknown is not associated problem

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
Co-authored-by: Yoshi Ri <yoshiyoshidetteiu@gmail.com>
technolojin pushed a commit to technolojin/autoware_launch that referenced this pull request Nov 25, 2024
autowarefoundation#825)

chore(stop_filter): extract stop_filter.param.yaml to autoware_launch (autowarefoundation#1145)

Extract stop_filter.param.yaml to autoware_launch

Signed-off-by: TaikiYamada4 <taiki.yamada@tier4.jp>
Co-authored-by: TaikiYamada4 <129915538+TaikiYamada4@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants