Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add sync-param-files #64

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jul 26, 2022

Signed-off-by: Takayuki Murooka takayuki5168@gmail.com

Description

add sync setting file to sync awf/autoware_launch/autoware_launch/config/tier4_*_launch with awf/autoware.universe/launch/tier4_*_launch/config

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as draft July 26, 2022 05:16
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168
Copy link
Contributor Author

@kenji-miyake
Sorry to mention you again. 🙇

I've created sync PR from autoware.universe/launch/tier4_launch/config -> autoware_launch/config/tier4_launch
How can I verify this sync setting file will work well.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review July 26, 2022 05:30
.github/sync-universe-param-files.yaml Outdated Show resolved Hide resolved
.github/workflows/sync-universe-param-files.yaml Outdated Show resolved Hide resolved
.github/workflows/sync-universe-param-files.yaml Outdated Show resolved Hide resolved
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@kenji-miyake kenji-miyake changed the title feat: add sync-universe-param-files feat: add sync-param-files Jul 26, 2022
@kenji-miyake kenji-miyake changed the title feat: add sync-param-files ci: add sync-param-files Jul 26, 2022
@takayuki5168
Copy link
Contributor Author

takayuki5168 commented Jul 26, 2022

@kenji-miyake I haven't checked if this PR works, but is it ok to merge this...? (After merged, we can enable this sync PR?)
I'm sorry, but I'm totally new to sync setting file.

@kenji-miyake
Copy link
Contributor

@takayuki5168 Yes, since this just adds a new workflow, I think it's okay to merge this.
We can test new workflows only after they're merged to the main branch.

@takayuki5168 takayuki5168 merged commit 3fb59c3 into autowarefoundation:main Jul 26, 2022
@kenji-miyake
Copy link
Contributor

But regarding the sync PR that will be generated by this workflow, we should review it.

@kenji-miyake
Copy link
Contributor

@takayuki5168 Trigger this workflow to test it.
https://github.com/autowarefoundation/autoware_launch/actions/workflows/sync-param-files.yaml

@takayuki5168 takayuki5168 mentioned this pull request Jul 26, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants