Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_launch): set larger max_area for pedestrian with umbrella #535

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Aug 29, 2023

Description

In tracking association, we use max_area gate to restrict human size under 1.0 m^2.
But, detected pedestrian sometimes become larger when with umbrella or something and it actually observed with TIER IV experiment.

So, I want to set larger value to this min_area related to pedestrian.

Setting Criteria: The larger umbrella is said to have a diameter of 1.2 m, so the area would be about 1.13, and considering the human area that would protrude from it, I thought it could be increased to about 1.5.

TIER IV INERNAL LINK: ticket

Tests performed

Tested in Lsim.

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@YoshiRi YoshiRi requested review from yukkysaito and miursh August 29, 2023 10:17
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi merged commit 449bb69 into autowarefoundation:main Aug 29, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Sep 12, 2023
…la (autowarefoundation#535)

set larger max_area for pedestrian with umbrella

Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 21, 2024
…arefoundation#535)

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants