Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_launch): add radar tracker parameter files and settings #470

Merged

Conversation

YoshiRi
Copy link
Contributor

@YoshiRi YoshiRi commented Jul 21, 2023

Description

Related with autowarefoundation/autoware.universe#4361.
That PR enables to track far object by radar detection.

This PR aims to add new radar tracking node parameter to launch files.

Tests performed

Tested in logsim.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

YoshiRi and others added 2 commits July 21, 2023 21:21
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
@kminoda
Copy link
Contributor

kminoda commented Jul 24, 2023

From which viewpoint shall I review this PR?

@miursh
Copy link
Contributor

miursh commented Jul 24, 2023

@YoshiRi
[Q] Add linear_motion_tracker.yaml is currently not used, as intended?

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Jul 24, 2023

@miursh
Since radar tracking need tuning process, this file is not currently used. I just put this file to be used in the future update.

My intentions is that we pass base path location which contains each tracker parameters and node will automatically load specific parameter files. So, I will pass the base directory to the nodes.

@YoshiRi
Copy link
Contributor Author

YoshiRi commented Jul 24, 2023

From which viewpoint shall I review this PR?

@kminoda
Sorry, I did not intended to call you, (May be automatically added?)

@ismetatabay
Copy link
Member

Hi @YoshiRi, @miursh, @kminoda I hope you are well 👍. We can't launch autoware without this PR merge due to merged universe PR.

@YoshiRi YoshiRi enabled auto-merge (squash) July 24, 2023 10:22
@YoshiRi
Copy link
Contributor Author

YoshiRi commented Jul 24, 2023

@ismetatabay Sorry, please wait for a while.

@miursh miursh changed the title add radar tracker parameter files and settings feat(autoware_launch): add radar tracker parameter files and settings Jul 24, 2023
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YoshiRi YoshiRi merged commit f3b44c4 into autowarefoundation:main Jul 24, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
…ce for pull_over (#470)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
chore: sync awf/autoware_launch
TomohitoAndo pushed a commit to TomohitoAndo/autoware_launch.awf that referenced this pull request Oct 20, 2023
mitukou1109 pushed a commit to mitukou1109/autoware_launch that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants