Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_simulator_component): add missing argument #465

Merged

Conversation

ismetatabay
Copy link
Member

Description

This PR necessary for prevent dying of planning_simulator.launch.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: ismetatabay <ismet@leodrive.ai>
@ismetatabay ismetatabay force-pushed the fix/map_based_prediction branch from 4ce035b to e9a6053 Compare July 19, 2023 13:17
@ismetatabay
Copy link
Member Author

@yukkysaito could you check it?, planning simulator cannot launch because missing parameters

@yukkysaito yukkysaito self-requested a review July 19, 2023 13:19
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ismetatabay ismetatabay merged commit 5939b17 into autowarefoundation:main Jul 19, 2023
@ismetatabay ismetatabay deleted the fix/map_based_prediction branch July 19, 2023 13:22
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Jul 25, 2023
…arefoundation#465)

* feat(autoware_launch): add pacmod_error to diad emergency list

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* fix dummy_diag

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* feat: add accel brake fault

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* Apply suggestions from code review

Co-authored-by: Kah Hooi Tan <41041286+tkhmy@users.noreply.github.com>

---------

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Kah Hooi Tan <41041286+tkhmy@users.noreply.github.com>
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Oct 23, 2023
fix(lane_change): adding lane expansion param for collision check
kyoichi-sugahara pushed a commit that referenced this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants