Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoware_launch): add lidar models params #450

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

ismetatabay
Copy link
Member

@ismetatabay ismetatabay commented Jul 13, 2023

Description

This PR provides migrating lidar detection model parameters from autoware_launch
Releated: autowarefoundation/autoware.universe#4250

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ismetatabay ismetatabay force-pushed the refactor/pointpainting branch 2 times, most recently from 5d5b740 to ea5aee9 Compare July 17, 2023 15:06
@ismetatabay ismetatabay marked this pull request as ready for review July 17, 2023 15:07
@ismetatabay ismetatabay marked this pull request as draft July 17, 2023 15:22
@ismetatabay ismetatabay changed the title refactor(autoware_launch): add pointpainting params refactor(autoware_launch): add lidar models params Jul 17, 2023
@ismetatabay ismetatabay force-pushed the refactor/pointpainting branch 3 times, most recently from 7254ac8 to dd796bc Compare July 17, 2023 17:01
@ismetatabay ismetatabay marked this pull request as ready for review July 17, 2023 17:01
@ismetatabay ismetatabay force-pushed the refactor/pointpainting branch 2 times, most recently from eb0b348 to d2ad8c3 Compare July 20, 2023 14:37
Signed-off-by: ismetatabay <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai>
Signed-off-by: ismetatabay <ismet@leodrive.ai>
@ismetatabay ismetatabay force-pushed the refactor/pointpainting branch from d2ad8c3 to 987cdd8 Compare July 20, 2023 14:43
@yukke42 yukke42 requested review from yukkysaito, yukke42 and miursh July 24, 2023 08:14
Copy link
Contributor

@yukke42 yukke42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukke42
Copy link
Contributor

yukke42 commented Jul 24, 2023

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
mitukou1109 pushed a commit to mitukou1109/autoware_launch that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants