Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ground_segmentation.param for vls16 #390

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

taikitanaka3
Copy link
Contributor

Description

because elevation grid is too small for vls 16 I fix this bug for awsim

/perception/obstacle_segmentation/range_cropped/pointcloud
image

/perception/obstacle_segmentation/single_frame/pointcloud_raw
before this PR
image

after this PR

video_1280.mp4

Internal

Tests performed

by awsim

Effects on system behavior

perception module

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c64541e) 0.00% compared to head (c73b94f) 0.00%.

Additional details and impacted files
@@         Coverage Diff         @@
##   awsim-stable   #390   +/-   ##
===================================
===================================

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@badai-nguyen badai-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit fef4b5b into awsim-stable Jun 8, 2023
@taikitanaka3 taikitanaka3 deleted the fix/perception_param_for_vls_16 branch June 8, 2023 07:45
rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
…on#390)

Signed-off-by: Tomohito Ando <tomohito.ando@tier4.jp>
rej55 pushed a commit to rej55/autoware_launch that referenced this pull request Jun 12, 2023
* fix(autoware_launch): remove unused arg

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* misc

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

* misc

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Mar 6, 2024
…bias-estimation

chore: disable yaw bias estimation of ekf
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants