Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "chore: sync param files (#161)" #209

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix: revert "chore: sync param files (#161)" #209

merged 1 commit into from
Feb 16, 2023

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Feb 15, 2023

This reverts commit 6fe7144.

Description

Reverts #161 (comment) for the reasons stated in @kminoda 's comment.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@xmfcx xmfcx requested a review from kminoda February 15, 2023 13:50
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks!!

@xmfcx xmfcx merged commit c224b8a into main Feb 16, 2023
@xmfcx xmfcx deleted the revert-161 branch February 16, 2023 06:20
purewater0901 pushed a commit that referenced this pull request Feb 28, 2023
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Mar 23, 2023
* change parameters of longitudinal controller
(tier4/autoware_launch.xx1#202)

* fix typo in localization util.launch.py (autowarefoundation#168)

* add rosbridge launch (autowarefoundation#175)

* add rosbridge launch

* fix TODO document

add link to pull request

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* fix double-byte character

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Co-authored-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: yabuta <makoto.yabuta@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
badai-nguyen pushed a commit to badai-nguyen/autoware_launch that referenced this pull request Mar 23, 2023
…ic drivable area (autowarefoundation#209) (autowarefoundation#212)

Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
tkimura4 pushed a commit to tkimura4/autoware_launch that referenced this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants