-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docker): remove ansible config files from runtime images #5192
Merged
oguzkaganozt
merged 3 commits into
upstream-universe-planning-control
from
remove-ansible-files
Sep 9, 2024
Merged
chore(docker): remove ansible config files from runtime images #5192
oguzkaganozt
merged 3 commits into
upstream-universe-planning-control
from
remove-ansible-files
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
oguzkaganozt
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f3666fc
into
upstream-universe-planning-control
17 checks passed
@oguzkaganozt Please don't merge by your self because I have 3 subsequent PRs before this PR. |
youtalk
added a commit
that referenced
this pull request
Sep 9, 2024
* update docker Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update action Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update readme Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix images Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * not download artifacts Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * add universe-planning-control-devel Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix copy Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * add copy Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix copy Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * add linefeed Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * add pcl Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update svg Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update readme Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * add planning-control image Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update svg Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * use ghcr.io Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update readme Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * not download artifacts Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * chore(docker): remove ansible config files from runtime images (#5192) * remove ansible files from runtime images Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * update rm -rf Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:openadkit
Issues or Features related to Open AD Kit
tag:run-health-check
Run health-check
type:containers
Docker containers, containerization of components, or container orchestration.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
universe-localization-mapping
runtime image #5189universe-devel
stage touniverse-planning-control-devel
stage #5194universe-planning-control
runtime image #5195This PR removes completely ansible config files which are copied at https://github.com/autowarefoundation/autoware/blob/main/docker/Dockerfile#L21 from runtime images.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.