Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): remove ansible config files from runtime images #5192

Merged

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Sep 7, 2024

Description

This PR removes completely ansible config files which are copied at https://github.com/autowarefoundation/autoware/blob/main/docker/Dockerfile#L21 from runtime images.

COPY setup-dev-env.sh ansible-galaxy-requirements.yaml amd64.env arm64.env /autoware/

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk self-assigned this Sep 7, 2024
@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit labels Sep 7, 2024
@youtalk youtalk marked this pull request as ready for review September 7, 2024 02:53
@youtalk youtalk added the tag:run-health-check Run health-check label Sep 7, 2024
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
@youtalk youtalk changed the base branch from main to upstream-universe-planning-control September 8, 2024 00:18
Copy link
Contributor

@oguzkaganozt oguzkaganozt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oguzkaganozt oguzkaganozt merged commit f3666fc into upstream-universe-planning-control Sep 9, 2024
17 checks passed
@oguzkaganozt oguzkaganozt deleted the remove-ansible-files branch September 9, 2024 08:26
@youtalk
Copy link
Member Author

youtalk commented Sep 9, 2024

@oguzkaganozt Please don't merge by your self because I have 3 subsequent PRs before this PR.
Screenshot 2024-09-09 at 20 43 45

youtalk added a commit that referenced this pull request Sep 9, 2024
* update docker

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* update action

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* update readme

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix images

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* not download artifacts

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* add universe-planning-control-devel

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix copy

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* add copy

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* fix copy

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* add linefeed

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* add pcl

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* update svg

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* update readme

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* add planning-control image

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* update svg

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* use ghcr.io

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* update readme

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* not download artifacts

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* chore(docker): remove ansible config files from runtime images (#5192)

* remove ansible files from runtime images

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

* update rm -rf

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>

---------

Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants