-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): no longer download artifacts on devel
image
#5023
Conversation
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
I'm okay with removing the artifact from the image, but do you have any idea about how the users run ML based nodes with docker?
I prefer option 2, but in that case, I think we should be updating the instructions in Autoware Documentation as well to tell the user to download the artifacts and mount them with run.sh script if they wish to use perception nodes. https://autowarefoundation.github.io/autoware-documentation/main/installation/autoware/docker-installation/#runtime-setup |
@mitsudome-r These reverted PRs need to revert again for the developers. Note that the |
This PR won't help CI because we are using Also posted here: |
Hmm, you mean we don't need this PR? |
I think it's ok to keep this PR because developers will probably prefer keeping the artifacts outside the image. But it won't help CI since we use another image for it. |
* feat(ci): disable `cache-to` option to run `health-check` from forked branch (autowarefoundation#5021) disable cache-to Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * feat: add single lidar sensor kit (autowarefoundation#4988) feat(autoware.repos): add single lidar sensor kit Signed-off-by: beginningfan <beginning.fan@autocore.ai> Co-authored-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> * fix(docker-build): fix ccache typo (autowarefoundation#5024) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> * feat(docker): no longer download artifacts on `devel` image (autowarefoundation#5023) not download artifacts on devel Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> --------- Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp> Signed-off-by: beginningfan <beginning.fan@autocore.ai> Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Co-authored-by: beginningfan <103237402+beginningfan@users.noreply.github.com> Co-authored-by: Ryohsuke Mitsudome <43976834+mitsudome-r@users.noreply.github.com>
Description
https://github.com/orgs/autowarefoundation/discussions/5007#discussioncomment-10086717
Based on this opinion, this PR excludes the artifacts from the
devel
image. The artifacts still continues to be included in theruntime
image.Tests performed
https://github.com/autowarefoundation/autoware/actions/runs/10052443863
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.