Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/gazebo with colcon #2109

Merged
merged 11 commits into from
Mar 13, 2019
Merged

Fix/gazebo with colcon #2109

merged 11 commits into from
Mar 13, 2019

Conversation

yukkysaito
Copy link
Contributor

Status

** DEVELOPMENT**

Description

bug fix https://github.com/CPFL/Autoware/issues/2108
gazebo setup error with colcon_release

@yukkysaito
Copy link
Contributor Author

@sgermanserrano @kfunaoka
I am doing colcon correspondence, but I got an error on CI. Autoware is read only on CI and file creation is impossible. Is there a good way to do it?

@yukkysaito
Copy link
Contributor Author

In CI of gitlab, such authority setting is not set and succeed

@sgermanserrano
Copy link

@yukkysaito what files do you need to create?

@sgermanserrano
Copy link

@yukkysaito it seems to be linked to ros-industrial/industrial_ci#210

@yukkysaito
Copy link
Contributor Author

Thank you!
It need to copy the files in the submodule to Autoware. The submodule is an external repository that provides gazebo world.

@sgermanserrano sgermanserrano requested a review from amc-nu March 11, 2019 15:19
@sgermanserrano
Copy link

@amc-nu it seems like industrial_ci loads the source as read-only

@amc-nu
Copy link
Member

amc-nu commented Mar 11, 2019

@sgermanserrano @yukkysaito do you know why the models are not being installed instead in the install space? Installer was working before.

@kfunaoka kfunaoka mentioned this pull request Mar 14, 2023
Closed
17 tasks
@sgermanserrano
Copy link

@yukkysaito can you remove the controller_manager duplication in simulation/gazebo_simulator/launcher/vehicle_gazebo_simulation_launcher/CMakeLists.txt?

@amc-nu
Copy link
Member

amc-nu commented Mar 12, 2019

@yukkysaito thanks for pushing the fix.
Can you please attend @sgermanserrano request?

@TakaHoribe can you please test with this branch if you can execute properly the simulator, and report back?
Thanks

@yukkysaito
Copy link
Contributor Author

@amc-nu @sgermanserrano Thank you for check

@yukkysaito
Copy link
Contributor Author

yukkysaito commented Mar 12, 2019 •
edited
Loading

It seems that all scripts in the runtime manager are no longer executable.

sh: 1: /home/yukihiro/workspace/Autoware/ros/install/runtime_manager/share/runtime_manager/scripts/gazebo.sh: Permission denied

I'll modify this

@yukkysaito yukkysaito merged commit 3626f6e into develop Mar 13, 2019
@yukkysaito yukkysaito deleted the fix/gazebo_with_colcon branch March 13, 2019 01:56
anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
@yukkysaito
Merge pull request autowarefoundation#2109 from CPFL/fix/gazebo_with_…
3ebbc7b 
…colcon

Fix/gazebo with colcon
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amc-nu amc-nu amc-nu approved these changes

@TakaHoribe TakaHoribe Awaiting requested review from TakaHoribe

@aohsato aohsato Awaiting requested review from aohsato

Assignees
No one assigned
Labels
version:autoware-ai Autoware.AI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yukkysaito @sgermanserrano @amc-nu @mitsudome-r