Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/shape estimation #1815

Merged
merged 41 commits into from
Jan 17, 2019
Merged

Feature/shape estimation #1815

merged 41 commits into from
Jan 17, 2019

Conversation

yukkysaito
Copy link
Contributor

Status

PRODUCTION / DEVELOPMENT

Description

autowarefoundation/autoware_ai#477
The estimation of bounding box is implemented the following paper
https://www.ri.cmu.edu/publications/efficient-l-shape-fitting-for-vehicle-detection-using-laser-scanners/

@yukkysaito yukkysaito requested a review from amc-nu December 26, 2018 08:55
@amc-nu
Copy link
Member

amc-nu commented Dec 26, 2018

@yukkysaito Please wait before merging, we need to add other tests and relocate the package to the object_filter package. autowarefoundation/autoware_ai#378

amc-nu
amc-nu previously requested changes Jan 9, 2019
Copy link
Member

@amc-nu amc-nu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the unit tests as we discussed before.

@yukkysaito
Copy link
Contributor Author

Add test code

@yukkysaito yukkysaito dismissed amc-nu’s stale review January 16, 2019 00:44

Added test code

Copy link

@sgermanserrano sgermanserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yukkysaito @amc-nu I've had a look at the code coverage. The unit tests seem to touch the functions that are not ROS-related. Thank you!

@yukkysaito yukkysaito merged commit 905ad3b into develop Jan 17, 2019
@yukkysaito yukkysaito deleted the feature/shape_estimation branch January 18, 2019 06:57
anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants