feat!: move diagnostics_module from localization_util to unverse_utils #9714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kminoda <koji.minoda@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
…le/move_to_universe_utils
soblin
reviewed
Dec 23, 2024
Comment on lines
59
to
60
| template <> | ||
| void DiagnosticsModule::add_key_value(const std::string & key, const bool & value); |
There was a problem hiding this comment.
Please remove these declarations because they do not make sense unless you declare them as "extern template" and define them in cpp files as specializations.
There was a problem hiding this comment.
How about this? c981570
| @@ -22,7 +22,7 @@ | |||
| #include <string> | |||
| #include <vector> | |||
|
|
|||
| namespace autoware::localization_util | |||
| namespace autoware::universe_utils | |||
| { | |||
| class DiagnosticsModule | |||
There was a problem hiding this comment.
IMO DiagnosticInterface is better
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
|
Thank you to all the reviewers. I've addressed all the comments. |
SakodaShintaro
approved these changes
Dec 25, 2024
There was a problem hiding this comment.
I checked the following test items:
-
planning_simulatorwith sample_map -
logging_simulatorwith sample_rosbag -
logging_simulatorwith awsim_gt_data(TIER IV INTERNAL) -
e2e_simulatorwith AWSIM v1.3.1
I also verified that the /diagnostics topic had the appropriate information.
LGTM, but please get soblin-san's approval before merging.
|
Sorry, pre-commit.ci is failing. |
Signed-off-by: kminoda <koji.minoda@tier4.jp>
|
@SakodaShintaro Thanks, fixed the precommit. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9714 +/- ##
==========================================
+ Coverage 29.72% 29.75% +0.03%
==========================================
Files 1451 1453 +2
Lines 108839 108888 +49
Branches 42741 42761 +20
==========================================
+ Hits 32348 32397 +49
+ Misses 73313 73312 -1
- Partials 3178 3179 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
soblin
approved these changes
Dec 25, 2024
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Dec 25, 2024
autowarefoundation#9714) * feat!: move diagnostics_module from localization_util to unverse_utils Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove diagnostics module from localization_util Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * minor fix in pose_initializer Signed-off-by: kminoda <koji.minoda@tier4.jp> * add test Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * remove unnecessary declaration Signed-off-by: kminoda <koji.minoda@tier4.jp> * module -> interface Signed-off-by: kminoda <koji.minoda@tier4.jp> * remove unnecessary equal expression Signed-off-by: kminoda <koji.minoda@tier4.jp> * revert the remove of template function Signed-off-by: kminoda <koji.minoda@tier4.jp> * style(pre-commit): autofix * use overload instead Signed-off-by: kminoda <koji.minoda@tier4.jp> * include what you use -- test_diagnostics_interface.cpp Signed-off-by: kminoda <koji.minoda@tier4.jp> --------- Signed-off-by: kminoda <koji.minoda@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DiagnosticsModuleinlocalization_utilis useful. Thus I would like to move it from the package touniverse_utilsRelated links
None
How was this PR tested?
Added unit test for the module
Notes for reviewers
None.
Interface changes
Package include path would change.
Effects on system behavior
None.