use overload instead

Signed-off-by: kminoda <koji.minoda@tier4.jp>
autowarefoundation · Dec 25, 2024 · c981570 · c981570
1 parent 82fafa7
commit c981570
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/common/autoware_universe_utils/include/autoware/universe_utils/ros/diagnostics_interface.hpp b/common/autoware_universe_utils/include/autoware/universe_utils/ros/diagnostics_interface.hpp
@@ -32,6 +32,8 @@ class DiagnosticInterface
   void add_key_value(const diagnostic_msgs::msg::KeyValue & key_value_msg);
   template <typename T>
   void add_key_value(const std::string & key, const T & value);
+  void add_key_value(const std::string & key, const std::string & value);
+  void add_key_value(const std::string & key, bool value);
   void update_level_and_message(const int8_t level, const std::string & message);
   void publish(const rclcpp::Time & publish_time_stamp);
 
@@ -54,11 +56,6 @@ void DiagnosticInterface::add_key_value(const std::string & key, const T & value
   add_key_value(key_value);
 }
 
-template <>
-void DiagnosticInterface::add_key_value(const std::string & key, const std::string & value);
-template <>
-void DiagnosticInterface::add_key_value(const std::string & key, const bool & value);
-
 }  // namespace autoware::universe_utils
 
 #endif  // AUTOWARE__UNIVERSE_UTILS__ROS__DIAGNOSTICS_INTERFACE_HPP_
diff --git a/common/autoware_universe_utils/src/ros/diagnostics_interface.cpp b/common/autoware_universe_utils/src/ros/diagnostics_interface.cpp
@@ -56,7 +56,6 @@ void DiagnosticInterface::add_key_value(const diagnostic_msgs::msg::KeyValue & k
   }
 }
 
-template <>
 void DiagnosticInterface::add_key_value(const std::string & key, const std::string & value)
 {
   diagnostic_msgs::msg::KeyValue key_value;
@@ -65,8 +64,7 @@ void DiagnosticInterface::add_key_value(const std::string & key, const std::stri
   add_key_value(key_value);
 }
 
-template <>
-void DiagnosticInterface::add_key_value(const std::string & key, const bool & value)
+void DiagnosticInterface::add_key_value(const std::string & key, bool value)
 {
   diagnostic_msgs::msg::KeyValue key_value;
   key_value.key = key;