-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crosswalk_traffic_light_estimator): add new package for crosswalk traffic light signals estimation #944
feat(crosswalk_traffic_light_estimator): add new package for crosswalk traffic light signals estimation #944
Conversation
Codecov Report
@@ Coverage Diff @@
## main #944 +/- ##
========================================
- Coverage 9.59% 9.57% -0.03%
========================================
Files 1042 1043 +1
Lines 71835 71981 +146
Branches 15588 15588
========================================
- Hits 6890 6889 -1
- Misses 58707 58853 +146
- Partials 6238 6239 +1
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
|
Are you still working on this PR? (Just checking because there were no updates for a month) |
Sorry for the late reply 🙇 I had been testing the logic at odaiba, and confirmed that the node works as expected 👍 |
228c949
to
e3a6f52
Compare
575225a
to
3fec7c4
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
420dc7c
to
fcee32f
Compare
03e2213
to
138e9c4
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
138e9c4
to
963947f
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
TEST at kashiwanoha WHITE CROSSWALK: related pedestrian's traffic signal is RED (crosswalk module don't look)
simplescreenrecorder-2022-07-01_13.26.01.mp4simplescreenrecorder-2022-07-01_11.59.47.mp4
simplescreenrecorder-2022-07-01_12.01.14.mp4simplescreenrecorder-2022-07-01_13.13.28.mp4 |
@satoshi-ota I wanna change the package name. how about |
@yukkysaito OK, I agree with you 👍 I'll fix it this PR and autoware_launch. |
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
TEST at odaiba WHITE CROSSWALK: related pedestrian's traffic signal is RED (crosswalk module don't look) simplescreenrecorder-2022-07-01_13.08.37.mp4simplescreenrecorder-2022-07-01_12.59.00.mp4simplescreenrecorder-2022-07-01_12.57.18.mp4simplescreenrecorder-2022-07-01_12.55.51.mp4 |
@yukkysaito I fixed package name in 9daaafb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…k traffic light signals estimation (tier4#944) * feat(traffic_light_estimator): add pedestrian traffic signal estimator Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): enable was_green Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): support specialize tag Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(traffic_light_estimator): cleanup callback Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix typo Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): pass by reference Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix copyright Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): modify build error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix build error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix input topic name Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): add flag to use last detect signal Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(traffic_light_estimator): add README Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(traffic_light_estimator): update flow diagram Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(crosswalk_traffic_light_estimator): package rename Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…k traffic light signals estimation (tier4#944) * feat(traffic_light_estimator): add pedestrian traffic signal estimator Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): enable was_green Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): support specialize tag Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(traffic_light_estimator): cleanup callback Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix typo Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): pass by reference Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix copyright Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): modify build error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix build error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix input topic name Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): add flag to use last detect signal Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(traffic_light_estimator): add README Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(traffic_light_estimator): update flow diagram Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(crosswalk_traffic_light_estimator): package rename Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…k traffic light signals estimation (tier4#944) * feat(traffic_light_estimator): add pedestrian traffic signal estimator Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): enable was_green Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): support specialize tag Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(traffic_light_estimator): cleanup callback Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix typo Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): pass by reference Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix copyright Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): modify build error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix build error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix input topic name Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): add flag to use last detect signal Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(traffic_light_estimator): add README Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(traffic_light_estimator): update flow diagram Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(crosswalk_traffic_light_estimator): package rename Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…k traffic light signals estimation (autowarefoundation#944) * feat(traffic_light_estimator): add pedestrian traffic signal estimator Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): enable was_green Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): support specialize tag Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(traffic_light_estimator): cleanup callback Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix typo Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): pass by reference Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix copyright Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): modify build error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix build error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix input topic name Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): add flag to use last detect signal Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(traffic_light_estimator): add README Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(traffic_light_estimator): update flow diagram Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(crosswalk_traffic_light_estimator): package rename Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…k traffic light signals estimation (tier4#944) * feat(traffic_light_estimator): add pedestrian traffic signal estimator Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): enable was_green Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): support specialize tag Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * refactor(traffic_light_estimator): cleanup callback Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix typo Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): pass by reference Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix copyright Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): modify build error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix build error Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(traffic_light_estimator): fix input topic name Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(traffic_light_estimator): add flag to use last detect signal Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(traffic_light_estimator): add README Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * docs(traffic_light_estimator): update flow diagram Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(crosswalk_traffic_light_estimator): package rename Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…-intersection-10-15 feat(intersection): cherry-pick latest changes
…n#944) update stop wall maintain time to 1 sec Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Description
Now, autoware supports and uses only vehicle traffic light signals, but I think if perception module detected or estimated not only vehicle traffic light signals but also crosswalk traffic light signals, behavior planning module could make better decision. (e.g. crosswalk module)
So, in this PR, I added
traffic_light_estimater
node in order to get crosswalk traffic light singals.This new node subscribes
autoware_auto_perception_msgs::msg::TrafficSignalArray
)autoware_auto_mapping_msgs::msg::HADMapBin
)autoware_auto_planning_msgs::msg::PathWithLaneId
)and publishes
autoware_auto_perception_msgs::msg::TrafficSignalArray
)Algorithm
Situation1
If traffic between pedestrians and vehicles is controlled by traffic signals, and signals of crosswalks intersecting STRAIGHT lanelets with
TrafficLight::GREEN
traffic state, the crosswalk traffic light signals prevent pedestrians from crossing, so in this situation, this node output crosswalk signals asTrafficLight::RED
.Situation2
If traffic between pedestrians and vehicles is controlled by traffic signals, and signals of crosswalks intersecting different turn direction lanelets (e.g. straight and left, left and right...) with
TrafficLight::GREEN
traffic state, the crosswalk traffic light signals prevent pedestrians from crossing, so in this situation, this node output crosswalk signals asTrafficLight::RED
.Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.