feat(behavior_path_planner_common): use azimuth for interpolatePose #9362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9362 +/- ##
==========================================
- Coverage 29.80% 29.79% -0.02%
==========================================
Files 1338 1344 +6
Lines 103252 103298 +46
Branches 40238 40242 +4
==========================================
+ Hits 30777 30780 +3
- Misses 69487 69530 +43
Partials 2988 2988
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
soblin
approved these changes
Nov 18, 2024
zulfaqar-azmi-t4
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 21, 2024
…utowarefoundation#9362) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rather than interpolating orientation, a smooth path can be generated by calculating the azimuth angle for the interpolated position.
before:
after #9361:
after #9362
Related links
Parent Issue:
How was this PR tested?
2024/11/18 https://evaluation.tier4.jp/evaluation/reports/a8e2f04f-8566-5840-9c91-8ca2acc36dc2/?project_id=prd_jt
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.