Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(goal_planner): do not insert shift end pose on pull over lane to path #9361

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Nov 18, 2024

Description

If the same pose is inserted for points with different lateral positions, it will not be smooth when interpolating with splines. It would be smoother if the same posture is not inserted.

before:

image

after #9361:

image

Related links

Parent Issue:

  • Link

How was this PR tested?

psim

2024/11/21 https://evaluation.tier4.jp/evaluation/reports/583046b1-fc82-5428-aef1-fa550491afab/?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@kosuke55 kosuke55 marked this pull request as ready for review November 18, 2024 09:52
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 18, 2024
Copy link

github-actions bot commented Nov 18, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 30.04%. Comparing base (d8087f4) to head (1db1b13).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9361      +/-   ##
==========================================
+ Coverage   28.96%   30.04%   +1.08%     
==========================================
  Files        1427     1345      -82     
  Lines      108253   103715    -4538     
  Branches    41398    40362    -1036     
==========================================
- Hits        31352    31166     -186     
+ Misses      73866    69538    -4328     
+ Partials     3035     3011      -24     
Flag Coverage Δ *Carryforward flag
differential 0.52% <ø> (?)
total 30.06% <ø> (+1.10%) ⬆️ Carriedforward from d8087f4

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

… path

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 merged commit 74ca3ab into autowarefoundation:main Nov 21, 2024
33 of 34 checks passed
@kosuke55 kosuke55 deleted the feat/not_end_pose branch November 21, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants