Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(factors_panel): sort by distance to stop/decel or point where it starts moving the steering #9346

Merged
merged 1 commit into from
Nov 18, 2024

fix(factors_panel): sort by distance to stop/decel or point where it …

c7779fb
Select commit
Loading
Failed to load commit list.
Merged

fix(factors_panel): sort by distance to stop/decel or point where it starts moving the steering #9346

fix(factors_panel): sort by distance to stop/decel or point where it …
c7779fb
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Nov 18, 2024 in 23s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Change in average Code Health of affected files: -0.02 (9.61 -> 9.59)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method velocity_steering_factors_panel.cpp: VelocitySteeringFactorsPanel::onSteeringFactors

Annotations

Check warning on line 175 in common/tier4_state_rviz_plugin/src/velocity_steering_factors_panel.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

VelocitySteeringFactorsPanel::onSteeringFactors already has high cyclomatic complexity, and now it increases in Lines of Code from 70 to 74. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
View more details on CodeScene Delta Analysis