Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(factors_panel): sort by distance to stop/decel or point where it starts moving the steering #9346

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

satoshi-ota
Copy link
Contributor

Description

Sort table col by distance.

Screenshot from 2024-11-18 09-53-04

Related links

Parent Issue:

  • Link

How was this PR tested?

Psim

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…starts moving the steering

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Nov 18, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link
Contributor

@h-ohta h-ohta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 18, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) November 18, 2024 08:41
@satoshi-ota satoshi-ota merged commit 9b0ba2d into autowarefoundation:main Nov 18, 2024
36 checks passed
@satoshi-ota satoshi-ota deleted the feat/sort-by-distance branch November 18, 2024 08:47
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 29.81%. Comparing base (08951b2) to head (c7779fb).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...viz_plugin/src/velocity_steering_factors_panel.cpp 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9346      +/-   ##
==========================================
- Coverage   29.81%   29.81%   -0.01%     
==========================================
  Files        1338     1338              
  Lines      103205   103216      +11     
  Branches    40210    40210              
==========================================
  Hits        30771    30771              
- Misses      69447    69458      +11     
  Partials     2987     2987              
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 29.81% <ø> (+<0.01%) ⬆️ Carriedforward from 08951b2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Dec 2, 2024
…starts moving the steering (autowarefoundation#9346)

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants