Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mission_planner): reroute with current route start pose when triggered by modifed goal #9136

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 22, 2024

Description

Rerouting from the current ego position during a run is a potential source of bugs, as it is necessary to be aware of cases where the planner's internally maintained lanes are no longer included in the route.
Rerouting with modifed goal assumes a slight modification near the goal lane. It is assumed that ego and goal are at least an extension of current_route. Therefore, the start pose of current_route is used as the start pose. This prevents the route from being shortened by rerouting.

Related links

Private Links:

How was this PR tested?

psim

2024/10/28 Evaluator

before (planned new route is short)

avoidance_pull_over-2024-10-21_20.11.39.mp4

after:

lc_avoid_goal-2024-10-22_12.34.10.mp4

2024/10/22 https://evaluation.tier4.jp/evaluation/reports/c6bf8b79-f69b-507e-a8b3-a2220d5dd22a/?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 22, 2024
Copy link

github-actions bot commented Oct 22, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 22, 2024
…ggered by modifed goal

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/modifed_goal_reroute branch from 3e558d8 to bf18da6 Compare October 22, 2024 04:20
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 28.25%. Comparing base (06adbc4) to head (b1b59a6).
Report is 50 commits behind head on main.

Files with missing lines Patch % Lines
...on_planner/src/mission_planner/mission_planner.cpp 0.00% 6 Missing ⚠️
...nning/autoware_route_handler/src/route_handler.cpp 40.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9136      +/-   ##
==========================================
- Coverage   28.26%   28.25%   -0.01%     
==========================================
  Files        1306     1310       +4     
  Lines      101091   101128      +37     
  Branches    39243    39250       +7     
==========================================
+ Hits        28573    28577       +4     
- Misses      69761    69792      +31     
- Partials     2757     2759       +2     
Flag Coverage Δ *Carryforward flag
differential 29.42% <25.00%> (?)
total 28.26% <ø> (+<0.01%) ⬆️ Carriedforward from 66e4742

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 merged commit e58a158 into autowarefoundation:main Oct 30, 2024
31 of 32 checks passed
@kosuke55 kosuke55 deleted the feat/modifed_goal_reroute branch October 30, 2024 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants