-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): suppress reseting root lanelet #9129
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
2057737
to
7402323
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9129 +/- ##
==========================================
- Coverage 28.26% 28.25% -0.02%
==========================================
Files 1306 1312 +6
Lines 101091 101136 +45
Branches 39243 39245 +2
==========================================
- Hits 28573 28572 -1
- Misses 69761 69807 +46
Partials 2757 2757
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@@ -135,7 +135,7 @@ BehaviorModuleOutput PlannerManager::run(const std::shared_ptr<PlannerData> & da | |||
const bool is_any_module_running = | |||
is_any_approved_module_running || is_any_candidate_module_running_or_idle; | |||
|
|||
updateCurrentRouteLanelet(data); | |||
updateCurrentRouteLanelet(data, is_any_approved_module_running); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if is_any_approved_module_running
, then when the ego path is on the middle of two lanes while avoiding, ReferencePath can suddenly switch to the next lane. To prevent it, while modules are running, do not call this (resetCurrentRouteLanelet is called when lane_change successfully finished.)
@satoshi-ota could you please check code owner? |
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
7402323
to
52961d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Description
suppress reseting root lanelet.
root lanelet is not updated when
Related links
Parent Issue:
How was this PR tested?
2024/10/21 https://evaluation.tier4.jp/evaluation/reports/698116ac-225c-5427-9e03-ada876229a76/?project_id=prd_jt
before
lc_avoid_goal-2024-10-17_11.18.37.mp4
after
avoidance_pull_over-2024-10-21_20.11.39.mp4
avoidance_pull_over-2024-10-21_19.43.54.mp4
I also checked that root lanelet update when lc -> pull over
lc_pull_over-2024-10-21_19.57.04.mp4
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.