Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(virtual_traffic_light): move to utils for unit test #9106

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Oct 17, 2024

Description

move some functions to utils for unit tests

Related links

Parent Issue:

How was this PR tested?

2024/10/17 https://evaluation.tier4.jp/evaluation/reports/12a8ef10-d489-5d4e-bcba-cb48a51df2ad/?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 17, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Project coverage is 27.38%. Comparing base (2be4572) to head (5c7bf6f).
Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
...elocity_virtual_traffic_light_module/src/utils.cpp 0.00% 38 Missing ⚠️
...elocity_virtual_traffic_light_module/src/utils.hpp 0.00% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9106      +/-   ##
==========================================
- Coverage   27.40%   27.38%   -0.02%     
==========================================
  Files        1302     1309       +7     
  Lines       95817    95877      +60     
  Branches    39127    39129       +2     
==========================================
+ Hits        26256    26257       +1     
- Misses      66942    67001      +59     
  Partials     2619     2619              
Flag Coverage Δ *Carryforward flag
differential 17.43% <0.00%> (?)
total 27.41% <ø> (+0.01%) ⬆️ Carriedforward from 2be4572

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55
Copy link
Contributor Author

kosuke55 commented Oct 21, 2024

@tkimura4 @shmpwk
could you please approve as code owner? 🙇
this PR is just moving functions.

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kosuke55 kosuke55 merged commit 641476d into autowarefoundation:main Oct 21, 2024
46 checks passed
@kosuke55 kosuke55 deleted the refactor/vtl_utils branch October 21, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants