Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_behavior_path_planner_common): disable feature of turning off blinker at low velocity #9005

refactor(turn_signal_decider): update turn signal requirements based …

aa28802
Select commit
Loading
Failed to load commit list.
Merged

feat(autoware_behavior_path_planner_common): disable feature of turning off blinker at low velocity #9005

refactor(turn_signal_decider): update turn signal requirements based …
aa28802
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Oct 2, 2024 in 37s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.08 (5.77 -> 5.70)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method turn_signal_decider.cpp: TurnSignalDecider::getIntersectionTurnSignalInfo

Annotations

Check warning on line 273 in planning/behavior_path_planner/autoware_behavior_path_planner_common/src/turn_signal_decider.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

TurnSignalDecider::getIntersectionTurnSignalInfo increases in cyclomatic complexity from 27 to 32, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 273 in planning/behavior_path_planner/autoware_behavior_path_planner_common/src/turn_signal_decider.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Bumpy Road Ahead

TurnSignalDecider::getIntersectionTurnSignalInfo increases from 5 to 6 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check notice on line 1 in planning/behavior_path_planner/autoware_behavior_path_planner_common/src/turn_signal_decider.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity

The mean cyclomatic complexity increases from 8.36 to 8.71, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.