-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoware_behavior_path_planner_common): disable feature of turning off blinker at low velocity #9005
feat(autoware_behavior_path_planner_common): disable feature of turning off blinker at low velocity #9005
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
…low velocity Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
9cebe20
to
308d837
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9005 +/- ##
==========================================
- Coverage 26.16% 26.15% -0.02%
==========================================
Files 1298 1304 +6
Lines 96978 97029 +51
Branches 39185 39192 +7
==========================================
+ Hits 25377 25380 +3
- Misses 68979 69025 +46
- Partials 2622 2624 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...ning/behavior_path_planner/autoware_behavior_path_planner_common/src/turn_signal_decider.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…on current velocity Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
2b179f4
into
autowarefoundation:main
…ng off blinker at low velocity (autowarefoundation#9005) * feat(turn_signal_decider): disable feature of turning off blinker at low velocity Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> --------- Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: prakash-kannaiah <prakashkanan.pk@gmail.com>
Description
When ego vehicle stops in the lane with turn_direction right or left, blinker turns off because of the following implementation.
The expected behavior for the scene is the keep turning on when the ego vehicle is on the lane with turn_direction is right or left.
So changed so that keep turning on blinker in this PR.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Effects on system behavior
None.