Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_behavior_path_planner_common): disable feature of turning off blinker at low velocity #9005

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Oct 2, 2024

Description

When ego vehicle stops in the lane with turn_direction right or left, blinker turns off because of the following implementation.

  const auto requires_turn_signal = [&](const auto & lane_attribute) {
    constexpr double stop_velocity_threshold = 0.1;
    return (
      lane_attribute == "right" || lane_attribute == "left" ||
      (lane_attribute == "straight" && current_vel < stop_velocity_threshold));
  };

image

The expected behavior for the scene is the keep turning on when the ego vehicle is on the lane with turn_direction is right or left.

So changed so that keep turning on blinker in this PR.

Related links

Parent Issue:

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Oct 2, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

…low velocity

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/disable_turn_off_blinker branch from 9cebe20 to 308d837 Compare October 2, 2024 04:34
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 2, 2024
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 26.15%. Comparing base (6e2cffb) to head (aa28802).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...or_path_planner_common/src/turn_signal_decider.cpp 41.66% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9005      +/-   ##
==========================================
- Coverage   26.16%   26.15%   -0.02%     
==========================================
  Files        1298     1304       +6     
  Lines       96978    97029      +51     
  Branches    39185    39192       +7     
==========================================
+ Hits        25377    25380       +3     
- Misses      68979    69025      +46     
- Partials     2622     2624       +2     
Flag Coverage Δ *Carryforward flag
differential 15.45% <41.66%> (?)
total 26.16% <ø> (-0.01%) ⬇️ Carriedforward from 308d837

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@satoshi-ota satoshi-ota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…on current velocity

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara merged commit 2b179f4 into autowarefoundation:main Oct 2, 2024
31 of 32 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the feat/disable_turn_off_blinker branch October 2, 2024 06:16
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
…ng off blinker at low velocity (autowarefoundation#9005)

* feat(turn_signal_decider): disable feature of turning off blinker at low velocity

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: prakash-kannaiah <prakashkanan.pk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants