Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(crosswalk): change exceptional handling #8956

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Sep 25, 2024

Description

Currently, after the backward path go over the default stop line, the crosswalk module do not treat as ego is yielding,
This PR change this behavior with the assumption that default stop pose is null only if the ego has passed the default stop pose.

Related links

#8853

How was this PR tested?

tier4 internal tests

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 25, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yuki-takagi-66 yuki-takagi-66 changed the title feat(crosswalk): fix(crosswalk): change exceptional handling Sep 25, 2024
@yuki-takagi-66 yuki-takagi-66 marked this pull request as ready for review September 25, 2024 10:05
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 26, 2024
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.46%. Comparing base (d25e9a1) to head (1934ba0).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8956      +/-   ##
==========================================
- Coverage   28.47%   28.46%   -0.02%     
==========================================
  Files        1314     1319       +5     
  Lines       98279    98330      +51     
  Branches    39961    39963       +2     
==========================================
+ Hits        27985    27986       +1     
- Misses      70166    70216      +50     
  Partials      128      128              
Flag Coverage Δ *Carryforward flag
differential 17.76% <ø> (?)
total 28.47% <ø> (ø) Carriedforward from d25e9a1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuki-takagi-66 yuki-takagi-66 merged commit 653ce0e into autowarefoundation:main Sep 26, 2024
47 of 48 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the takagi/crosswalk/go-over-behevior branch September 26, 2024 05:24
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
Signed-off-by: prakash-kannaiah <prakashkanan.pk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants