Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosswalk)!: update stop position caluculation #8853

Conversation

yuki-takagi-66
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 commented Sep 11, 2024

Description

This PR updates the algorithm for calculating the stop position for pedestrians.

Except for the exceptional behavior, the updated algorithm is as follows

  1. select the nearest stop position from the map and the pedestrians
  2. modify or select the stop position, taking acceleration and limit safety margin distance into account.
  3. check if the selected stopping point is appropriate for the braking distance.

Related links

launch PR: autowarefoundation/autoware_launch#1162

How was this PR tested?

psim and tier4 internal tests

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Sep 11, 2024
Copy link

github-actions bot commented Sep 11, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yuki-takagi-66 yuki-takagi-66 changed the title Takagi/crosswalk/add new stop position feat(crosswalk)!: update stop position caluculation Sep 11, 2024
@yuki-takagi-66 yuki-takagi-66 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Sep 11, 2024
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label Sep 13, 2024
@yuki-takagi-66 yuki-takagi-66 added the run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 12.19512% with 72 lines in your changes missing coverage. Please review.

Project coverage is 27.78%. Comparing base (64453f2) to head (781f601).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% 72 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8853      +/-   ##
==========================================
- Coverage   27.80%   27.78%   -0.03%     
==========================================
  Files        1325     1330       +5     
  Lines       98809    98910     +101     
  Branches    39631    39656      +25     
==========================================
+ Hits        27476    27481       +5     
- Misses      71248    71344      +96     
  Partials       85       85              
Flag Coverage Δ *Carryforward flag
differential 17.78% <12.19%> (?)
total 27.80% <ø> (+<0.01%) ⬆️ Carriedforward from 64453f2

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yuki Takagi <yuki.takagi@tier4.jp>
@yuki-takagi-66 yuki-takagi-66 force-pushed the takagi/crosswalk/add-new-stop-position branch from 75af4f9 to 781f601 Compare September 13, 2024 10:04
@yuki-takagi-66 yuki-takagi-66 merged commit b000f6e into autowarefoundation:main Sep 13, 2024
29 of 32 checks passed
@yuki-takagi-66 yuki-takagi-66 deleted the takagi/crosswalk/add-new-stop-position branch September 13, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) run:deploy-docs Mark for deploy-docs action generation. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants