Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rtc_interface, lane_change): check state transition for cooperate status #8855

Merged
merged 5 commits into from
Sep 12, 2024

change rtc cooperate status according to module status

58e1ae2
Select commit
Loading
Failed to load commit list.
Merged

feat(rtc_interface, lane_change): check state transition for cooperate status #8855

change rtc cooperate status according to module status
58e1ae2
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Sep 12, 2024 in 39s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.34 (8.61 -> 8.27)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional rtc_interface.cpp: RTCInterface::updateCooperateStatus

Annotations

Check notice on line 305 in planning/autoware_rtc_interface/src/rtc_interface.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ New issue: Complex Method

RTCInterface::updateCooperateStatus has a cyclomatic complexity of 12, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 296 in planning/autoware_rtc_interface/src/rtc_interface.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

RTCInterface::updateCooperateStatus has 2 complex conditionals with 5 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.