Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(raw_vehicle_cmd_converter): set convert_actuation_to_steering_status false by default #8668

Conversation

kosuke55
Copy link
Contributor

Description

In #8588, we introduced new parameter, but it is hard to modify all the prameter file for many vehicles. so set false by default to keep the previous behavior with out parameter file modification.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

…atus false by default

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@github-actions github-actions bot added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label Aug 29, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kosuke55 kosuke55 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 29, 2024
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 24.16%. Comparing base (47275fb) to head (765386a).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...le/autoware_raw_vehicle_cmd_converter/src/node.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8668      +/-   ##
==========================================
- Coverage   24.18%   24.16%   -0.02%     
==========================================
  Files        1399     1400       +1     
  Lines      102126   102151      +25     
  Branches    38769    38777       +8     
==========================================
- Hits        24700    24686      -14     
- Misses      74900    74959      +59     
+ Partials     2526     2506      -20     
Flag Coverage Δ *Carryforward flag
differential 4.58% <0.00%> (?)
total 24.17% <ø> (-0.02%) ⬇️ Carriedforward from 7011ea1

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kosuke55 kosuke55 merged commit 67d5e68 into autowarefoundation:main Aug 29, 2024
41 checks passed
@kosuke55 kosuke55 deleted the feat/convert_actuation_to_steering_status branch August 29, 2024 08:09
kosuke55 added a commit to tier4/autoware.universe that referenced this pull request Aug 29, 2024
…atus false by default (autowarefoundation#8668)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…atus false by default (autowarefoundation#8668)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…atus false by default (autowarefoundation#8668)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants