Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ekf_localizer): removed proc_cov_*_d_ from EKFLocalizer #8640

Conversation

SakodaShintaro
Copy link
Contributor

Description

Currently, proc_cov_*_d_ are calculated in ekf_module.cpp.

void EKFModule::predict_with_delay(const double dt)
{
const Eigen::MatrixXd x_curr = kalman_filter_.getLatestX();
const Eigen::MatrixXd p_curr = kalman_filter_.getLatestP();
const double proc_cov_vx_d = std::pow(params_.proc_stddev_vx_c * dt, 2.0);
const double proc_cov_wz_d = std::pow(params_.proc_stddev_wz_c * dt, 2.0);
const double proc_cov_yaw_d = std::pow(params_.proc_stddev_yaw_c * dt, 2.0);
const Vector6d x_next = predict_next_state(x_curr, dt);
const Matrix6d a = create_state_transition_matrix(x_curr, dt);
const Matrix6d q = process_noise_covariance(proc_cov_yaw_d, proc_cov_vx_d, proc_cov_wz_d);
kalman_filter_.predictWithDelay(x_next, a, q);
}

So we can remove these variables from EKFLocalizer.

How was this PR tested?

I have confirmed that logging_simulator with AWSIM GT rosbag works well and the mean error is almost the same as before.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 27, 2024
@SakodaShintaro SakodaShintaro self-assigned this Aug 27, 2024
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label Aug 27, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.11%. Comparing base (a64566e) to head (d781b4c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8640      +/-   ##
==========================================
- Coverage   24.11%   24.11%   -0.01%     
==========================================
  Files        1399     1399              
  Lines      102423   102419       -4     
  Branches    38926    38927       +1     
==========================================
- Hits        24702    24697       -5     
  Misses      75223    75223              
- Partials     2498     2499       +1     
Flag Coverage Δ *Carryforward flag
differential 31.15% <ø> (?)
total 24.11% <ø> (-0.01%) ⬇️ Carriedforward from a64566e

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SakodaShintaro SakodaShintaro merged commit 94b5c33 into autowarefoundation:main Aug 27, 2024
38 of 41 checks passed
@SakodaShintaro SakodaShintaro deleted the refactor/removed_proc_cov_in_ekf branch August 27, 2024 09:51
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…owarefoundation#8640)

Removed proc_cov_*_d_ from EKFLocalizer

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
batuhanbeytekin pushed a commit to batuhanbeytekin/autoware.universe that referenced this pull request Sep 2, 2024
…owarefoundation#8640)

Removed proc_cov_*_d_ from EKFLocalizer

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
…owarefoundation#8640)

Removed proc_cov_*_d_ from EKFLocalizer

Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants