-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ekf_localizer): removed proc_cov_*_d_ from EKFLocalizer #8640
refactor(ekf_localizer): removed proc_cov_*_d_ from EKFLocalizer #8640
Conversation
Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8640 +/- ##
==========================================
- Coverage 24.11% 24.11% -0.01%
==========================================
Files 1399 1399
Lines 102423 102419 -4
Branches 38926 38927 +1
==========================================
- Hits 24702 24697 -5
Misses 75223 75223
- Partials 2498 2499 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
94b5c33
into
autowarefoundation:main
…owarefoundation#8640) Removed proc_cov_*_d_ from EKFLocalizer Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
…owarefoundation#8640) Removed proc_cov_*_d_ from EKFLocalizer Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp> Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
…owarefoundation#8640) Removed proc_cov_*_d_ from EKFLocalizer Signed-off-by: Shintaro Sakoda <shintaro.sakoda@tier4.jp>
Description
Currently,
proc_cov_*_d_
are calculated in ekf_module.cpp.autoware.universe/localization/ekf_localizer/src/ekf_module.cpp
Lines 182 to 195 in a64566e
So we can remove these variables from EKFLocalizer.
How was this PR tested?
I have confirmed that logging_simulator with AWSIM GT rosbag works well and the mean error is almost the same as before.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.