Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_pointcloud_preprocessor): blockage diag node add runtime error when the parameter is wrong #8564

Merge branch 'main' into fix/blockage_diag_should_throw_error_message

caef352
Select commit
Loading
Failed to load commit list.
Merged

fix(autoware_pointcloud_preprocessor): blockage diag node add runtime error when the parameter is wrong #8564

Merge branch 'main' into fix/blockage_diag_should_throw_error_message
caef352
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Aug 27, 2024 in 38s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.03 (6.97 -> 6.94)

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method blockage_diag_node.cpp: BlockageDiagComponent::filter

Annotations

Check warning on line 200 in sensing/autoware_pointcloud_preprocessor/src/blockage_diag/blockage_diag_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method

BlockageDiagComponent::filter increases in cyclomatic complexity from 27 to 29, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 200 in sensing/autoware_pointcloud_preprocessor/src/blockage_diag/blockage_diag_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Bumpy Road Ahead

BlockageDiagComponent::filter increases from 8 to 9 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.