fix(autoware_pointcloud_preprocessor): blockage diag node add runtime error when the parameter is wrong #8564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
sensing/autoware_pointcloud_preprocessor/src/blockage_diag/blockage_diag_node.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com>
|
@badai-nguyen Could you recheck this, thanks! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8564 +/- ##
==========================================
- Coverage 24.11% 23.93% -0.19%
==========================================
Files 1399 1400 +1
Lines 102423 101971 -452
Branches 38926 38765 -161
==========================================
- Hits 24702 24402 -300
+ Misses 75223 75118 -105
+ Partials 2498 2451 -47
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sensing/autoware_pointcloud_preprocessor/src/blockage_diag/blockage_diag_node.cpp
Outdated
Show resolved
Hide resolved
sensing/autoware_pointcloud_preprocessor/src/blockage_diag/blockage_diag_node.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
|
@badai-nguyen Thanks for your suggestion!! I added the logging message. Thanks! |
@vividf Yes, I agree, actually I missed |
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Sep 2, 2024
… error when the parameter is wrong (autowarefoundation#8564) * fix: add runtime error Signed-off-by: vividf <yihsiang.fang@tier4.jp> * Update blockage_diag_node.cpp Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com> * fix: add RCLCPP error logging Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove unused variable Signed-off-by: vividf <yihsiang.fang@tier4.jp> --------- Signed-off-by: vividf <yihsiang.fang@tier4.jp> Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com>
batuhanbeytekin
pushed a commit
to batuhanbeytekin/autoware.universe
that referenced
this pull request
Sep 2, 2024
… error when the parameter is wrong (autowarefoundation#8564) * fix: add runtime error Signed-off-by: vividf <yihsiang.fang@tier4.jp> * Update blockage_diag_node.cpp Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com> * fix: add RCLCPP error logging Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove unused variable Signed-off-by: vividf <yihsiang.fang@tier4.jp> --------- Signed-off-by: vividf <yihsiang.fang@tier4.jp> Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com> Signed-off-by: Batuhan Beytekin <batuhanbeytekin@gmail.com>
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Sep 18, 2024
… error when the parameter is wrong (autowarefoundation#8564) * fix: add runtime error Signed-off-by: vividf <yihsiang.fang@tier4.jp> * Update blockage_diag_node.cpp Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com> * fix: add RCLCPP error logging Signed-off-by: vividf <yihsiang.fang@tier4.jp> * chore: remove unused variable Signed-off-by: vividf <yihsiang.fang@tier4.jp> --------- Signed-off-by: vividf <yihsiang.fang@tier4.jp> Co-authored-by: badai nguyen <94814556+badai-nguyen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TIER4_INTERNAL_LINK
When the user sets the parameter "vertical_bins" less than the number of LiDAR's channel, it will output a runtime error to let the user know they should set the vertical_bins correctly instead of only getting the
malloc()error.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.