Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): additional fix for 8520 #8561

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Aug 21, 2024

Description

additional fix for #8520

For occlusion detection lanelet, adjacency_matrix can be null. Also I added if terminal_lanelets are included in detection_lanelets.

Related links

#8520
Parent Issue:

  • Link

How was this PR tested?

https://evaluation.tier4.jp/evaluation/reports/9c69c9d4-e05f-522a-a30e-3b103cdbc6c1?project_id=prd_jt

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

soblin added 3 commits August 21, 2024 18:10
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Aug 21, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 53.12500% with 15 lines in your changes missing coverage. Please review.

Project coverage is 23.94%. Comparing base (cfe527b) to head (cbd272c).
Report is 5 commits behind head on main.

Files Patch % Lines
...behavior_velocity_intersection_module/src/util.cpp 54.83% 14 Missing ⚠️
...ion_module/src/scene_intersection_prepare_data.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8561      +/-   ##
==========================================
- Coverage   23.94%   23.94%   -0.01%     
==========================================
  Files        1382     1387       +5     
  Lines      101992   102050      +58     
  Branches    38847    38859      +12     
==========================================
+ Hits        24424    24433       +9     
- Misses      75076    75121      +45     
- Partials     2492     2496       +4     
Flag Coverage Δ *Carryforward flag
differential 17.74% <53.12%> (?)
total 23.94% <ø> (-0.01%) ⬇️ Carriedforward from f047525

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin enabled auto-merge (squash) August 21, 2024 11:01
@soblin soblin merged commit 39ef4e9 into autowarefoundation:main Aug 21, 2024
37 of 39 checks passed
@soblin soblin deleted the fix/intersection-8520 branch August 21, 2024 11:05
soblin added a commit to tier4/autoware.universe that referenced this pull request Aug 21, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 27, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
saka1-s pushed a commit to tier4/autoware.universe that referenced this pull request Dec 19, 2024
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
TetsuKawa pushed a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2025
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants