Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(intersection): fix topological sort for complicated intersection #8520

Merged
merged 4 commits into from
Aug 20, 2024
Merged

feat(intersection): fix topological sort for complicated intersection #8520

merged 4 commits into from
Aug 20, 2024

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Aug 19, 2024 •
edited
Loading

Description

Related links

https://tier4.atlassian.net/browse/RT0-31351

before this PR

some attention area is missing

image

some occlusion attention area is enclaved

image

after this PR

attention area is not missing

image

occlusion attention area is not enclaved

image

How was this PR tested?

map with loop

gives same result

before

image

after

image

complicated map

before

attention area

image

occlusion attention area

after

attention area
image

occlusion attention area

image

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Aug 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 19, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin force-pushed the feat/intersection/complicated-intersection branch 2 times, most recently from f9bf4c6 to 599ac77 Compare August 19, 2024 03:08
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label Aug 19, 2024
@soblin soblin requested a review from yhisaki August 19, 2024 03:58
@soblin
for enclave occlusion detection lanelet
df7eb88 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin force-pushed the feat/intersection/complicated-intersection branch from 599ac77 to df7eb88 Compare August 19, 2024 04:07
@soblin soblin added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 19, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 21.42857% with 55 lines in your changes missing coverage. Please review.

Project coverage is 23.90%. Comparing base (7424c48) to head (788ca24).
Report is 12 commits behind head on main.

Files Patch % Lines
...ion_module/src/scene_intersection_prepare_data.cpp 0.00% 34 Missing ⚠️
...behavior_velocity_intersection_module/src/util.cpp 41.66% 21 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8520      +/-   ##
==========================================
- Coverage   23.91%   23.90%   -0.02%     
==========================================
  Files        1381     1386       +5     
  Lines      101939   101964      +25     
  Branches    38822    38822              
==========================================
- Hits        24376    24371       -5     
+ Misses      75119    75092      -27     
- Partials     2444     2501      +57
Flag Coverage Δ *Carryforward flag
differential 20.70% <21.42%> (?)
total 23.90% <ø> (-0.01%) ⬇️ Carriedforward from 1b60052

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yhisaki yhisaki self-assigned this Aug 19, 2024
@yhisaki
some refactorings and modify doxygen
e61b167 
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
yhisaki
yhisaki approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@yhisaki yhisaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@soblin
I added some changes to improve code. Please check e61b167 !

@soblin
fix ci
1b60052 
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@soblin soblin added run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) and removed run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Aug 20, 2024
@soblin soblin enabled auto-merge (squash) August 20, 2024 00:10
@soblin soblin merged commit af01e3f into autowarefoundation:main Aug 20, 2024
27 of 30 checks passed
@soblin soblin deleted the feat/intersection/complicated-intersection branch August 20, 2024 11:04
@soblin soblin mentioned this pull request Aug 21, 2024
Closed
soblin added a commit to tier4/autoware.universe that referenced this pull request Aug 21, 2024
@soblin
Revert "feat(intersection): fix topological sort for complicated inte…
1c45431 
…rsection (autowarefoundation#8520)"

This reverts commit af01e3f.
soblin added a commit to tier4/autoware.universe that referenced this pull request Aug 21, 2024
@soblin
Revert "feat(intersection): fix topological sort for complicated inte…
b41dcff 
…rsection (autowarefoundation#8520)"

This reverts commit af01e3f.
@soblin soblin mentioned this pull request Aug 21, 2024
Merged
soblin added a commit to tier4/autoware.universe that referenced this pull request Aug 21, 2024
@soblin @yhisaki
feat(intersection): fix topological sort for complicated intersection (…
a4b4459 
…autowarefoundation#8520)

* for enclave occlusion detection lanelet

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* some refactorings and modify doxygen

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* fix ci

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Co-authored-by: Y.Hisaki <yhisaki31@gmail.com>
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
@soblin @yhisaki @kyoichi-sugahara
feat(intersection): fix topological sort for complicated intersection (…
fa40d6d 
…autowarefoundation#8520)

* for enclave occlusion detection lanelet

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* some refactorings and modify doxygen

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* fix ci

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Co-authored-by: Y.Hisaki <yhisaki31@gmail.com>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 27, 2024
@soblin @yhisaki @saka1-s
feat(intersection): fix topological sort for complicated intersection (…
2ae8bb8 
…autowarefoundation#8520)

* for enclave occlusion detection lanelet

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* some refactorings and modify doxygen

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* fix ci

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Co-authored-by: Y.Hisaki <yhisaki31@gmail.com>
saka1-s pushed a commit to tier4/autoware.universe that referenced this pull request Dec 19, 2024
@soblin @yhisaki @saka1-s
feat(intersection): fix topological sort for complicated intersection (…
570c1dc 
…autowarefoundation#8520)

* for enclave occlusion detection lanelet

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* some refactorings and modify doxygen

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* fix ci

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Co-authored-by: Y.Hisaki <yhisaki31@gmail.com>
TetsuKawa pushed a commit to tier4/autoware.universe that referenced this pull request Jan 23, 2025
@soblin @yhisaki @TetsuKawa
feat(intersection): fix topological sort for complicated intersection (…
6a89e82 
…autowarefoundation#8520)

* for enclave occlusion detection lanelet

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* some refactorings and modify doxygen

Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>

* fix ci

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: Y.Hisaki <yhisaki31@gmail.com>
Co-authored-by: Y.Hisaki <yhisaki31@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhisaki yhisaki yhisaki approved these changes

@shmpwk shmpwk shmpwk approved these changes

@rej55 rej55 Awaiting requested review from rej55 rej55 is a code owner

@isamu-takagi isamu-takagi Awaiting requested review from isamu-takagi isamu-takagi is a code owner

@tkimura4 tkimura4 Awaiting requested review from tkimura4 tkimura4 is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@takayuki5168 takayuki5168 Awaiting requested review from takayuki5168 takayuki5168 is a code owner

Assignees

@yhisaki yhisaki

Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@soblin @yhisaki @shmpwk