feat(pid_longitudinal_controller)!: add acceleration feedback block #8325
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Aug 26, 2024 in 48s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.27 (6.09 -> 5.82)
- Declining Code Health: 2 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Large Method pid_longitudinal_controller.cpp: PidLongitudinalController::paramCallback
- Large Method pid_longitudinal_controller.cpp: PidLongitudinalController::calcCtrlCmd
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Complex Method
PidLongitudinalController::updateControlState already has high cyclomatic complexity, and now it increases in Lines of Code from 138 to 139. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
PidLongitudinalController::paramCallback increases from 111 to 118 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Large Method
PidLongitudinalController::calcCtrlCmd has 80 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Loading